Validate shared information as url #261

Closed
opened 2019-12-03 19:56:34 +01:00 by dshanske · 4 comments
dshanske commented 2019-12-03 19:56:34 +01:00 (Migrated from github.com)

Some apps share a title and a URL, which Indigenous puts in the url field...It should validate that the shared information is a url.

Some apps share a title and a URL, which Indigenous puts in the url field...It should validate that the shared information is a url.
swentel commented 2019-12-12 14:50:56 +01:00 (Migrated from github.com)

Wow, the app even crashes when you share a url to the note post type - I clearly don't use it as much :)

Wow, the app even crashes when you share a url to the note post type - I clearly don't use it as much :)
swentel commented 2019-12-12 15:43:55 +01:00 (Migrated from github.com)

So indeed - when you share a url from a webpage, you also get the title of the page as subject. The url is in the variable I check in the current version.

I can pass on the subject too, but it only seems useful for article as far as I can see. So not exactly sure what action I should take here.

So indeed - when you share a url from a webpage, you also get the title of the page as subject. The url is in the variable I check in the current version. I can pass on the subject too, but it only seems useful for article as far as I can see. So not exactly sure what action I should take here.
dshanske commented 2019-12-12 19:25:11 +01:00 (Migrated from github.com)

At the least, strip the URL and send only that.

At the least, strip the URL and send only that.
swentel commented 2019-12-13 07:56:48 +01:00 (Migrated from github.com)

I think it's ok now. We can always iterate further. At least the crash is fixed :)

I think it's ok now. We can always iterate further. At least the crash is fixed :)
This discussion has been locked. Commenting is limited to contributors.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
inhji/indiepass-android#261
No description provided.