Known Login issue #25

Closed
opened 2018-04-11 16:37:05 +02:00 by zoglesby · 10 comments
zoglesby commented 2018-04-11 16:37:05 +02:00 (Migrated from github.com)

When trying to login with my known site I authenticate, grant permission and it returns back to the app login page. I get the validating code message and then an "Authorization failed" message.

I have checked that the auth tokens are being created on the server side. Let me know what I can do to provide you with more information to work on this.

The domain that I am using in https://zach.oglesby.co and it works with alltogethernow.io and Indigenous iOS.

When trying to login with my known site I authenticate, grant permission and it returns back to the app login page. I get the validating code message and then an "Authorization failed" message. I have checked that the auth tokens are being created on the server side. Let me know what I can do to provide you with more information to work on this. The domain that I am using in https://zach.oglesby.co and it works with alltogethernow.io and Indigenous iOS.
swentel commented 2018-04-11 16:48:17 +02:00 (Migrated from github.com)

So, Ironically, the "Authentication failed" is used twice in my code so I don't have a clear pointer for myself. I'm going to add more debugging information to the code and roll out a new version as soon as possible, that will make bug reports easier :)

I'll check the https://withknown.com/ project too to figure out if the authentication works different or not (although it shouldn't as far as I know)

So, Ironically, the "Authentication failed" is used twice in my code so I don't have a clear pointer for myself. I'm going to add more debugging information to the code and roll out a new version as soon as possible, that will make bug reports easier :) I'll check the https://withknown.com/ project too to figure out if the authentication works different or not (although it shouldn't as far as I know)
pstuifzand commented 2018-04-11 17:06:25 +02:00 (Migrated from github.com)

There is not response_type=code used, I guess.

(Originally published at: https://publog.stuifzandapp.com/posts/529)

There is not response_type=code used, I guess. (Originally published at: https://publog.stuifzandapp.com/posts/529)
swentel commented 2018-04-11 17:50:02 +02:00 (Migrated from github.com)

hmm you're right, that's not set, hopefully it's as simple as that.
Interesting that indieauth.com doesn't complain about that.

hmm you're right, that's not set, hopefully it's as simple as that. Interesting that indieauth.com doesn't complain about that.
swentel commented 2018-04-11 18:48:41 +02:00 (Migrated from github.com)

@zoglesby I pushed a new release, should be available soon.

I added more debug messages to get a clearer view on what might go wrong.
But let's just simply hope that adding the response_type fixed it already, that would be awesome.

@zoglesby I pushed a new release, should be available soon. I added more debug messages to get a clearer view on what might go wrong. But let's just simply hope that adding the response_type fixed it already, that would be awesome.
zoglesby commented 2018-04-11 18:58:21 +02:00 (Migrated from github.com)

The new error is “Value acess_token of Java.lang.String cannot be converted to json_object”

<a href="https://github.com/swentel/indigenous-android/issues/25#issuecomment-380520522" class="u-in-reply-to"></a>The new error is “Value acess_token of Java.lang.String cannot be converted to json_object”
swentel commented 2018-04-11 19:25:39 +02:00 (Migrated from github.com)

Aha, that sounds like the response from the token endpoint is not returning json but probably just plain text. Good pointer! Will digg a bit through the code of Known (or other clients).

Aha, that sounds like the response from the token endpoint is not returning json but probably just plain text. Good pointer! Will digg a bit through the code of Known (or other clients).
swentel commented 2018-04-11 19:35:26 +02:00 (Migrated from github.com)

So it seems the iOS client had trouble with that too and added legacy code. Eddie opened an issue which is now closed but did not fix the issue properly afaics.

Will check to add legacy code too.

So it seems the iOS client had trouble with that too and added legacy code. Eddie opened an issue which is now closed but did not fix the issue properly afaics. Will check to add legacy code too.
swentel commented 2018-04-11 21:14:22 +02:00 (Migrated from github.com)

@zoglesby So another release, will come up in a few minutes.
Crossing fingers that it will work now, added code that should be able to get the access token from the body in an url encoded string.

@zoglesby So another release, will come up in a few minutes. Crossing fingers that it will work now, added code that should be able to get the access token from the body in an url encoded string.
zoglesby commented 2018-04-11 23:09:34 +02:00 (Migrated from github.com)

That fixed the issue.

<a href="https://github.com/swentel/indigenous-android/issues/25#issuecomment-380520522" class="u-in-reply-to"></a>That fixed the issue.
swentel commented 2018-04-11 23:33:27 +02:00 (Migrated from github.com)

Awesome!

Awesome!
This discussion has been locked. Commenting is limited to contributors.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
inhji/indiepass-android#25
No description provided.