Fix the read more button #127

Closed
opened 2018-10-09 15:30:11 +02:00 by swentel · 6 comments
swentel commented 2018-10-09 15:30:11 +02:00 (Migrated from github.com)

it's not entirely ok and it makes so that we have to much space as well with the height and such. It should automatically scale

Another aspect is that p tags are getting double new lines - which actually makes sense, but it's kind of annoying at the last one.

using https://github.com/Blogcat/Android-ExpandableTextView now, but let's try https://github.com/Manabu-GT/ExpandableTextView

it's not entirely ok and it makes so that we have to much space as well with the height and such. It should automatically scale Another aspect is that p tags are getting double new lines - which actually makes sense, but it's kind of annoying at the last one. using https://github.com/Blogcat/Android-ExpandableTextView now, but let's try https://github.com/Manabu-GT/ExpandableTextView
swentel commented 2018-12-30 23:10:34 +01:00 (Migrated from github.com)

this works so much better now

this works so much better now
swentel commented 2019-01-03 17:14:12 +01:00 (Migrated from github.com)

Still not perfect - it leaves gaps when the button has been opened

Still not perfect - it leaves gaps when the button has been opened
swentel commented 2019-01-04 14:27:39 +01:00 (Migrated from github.com)

Looked at it for a couple of hours and couldn't find a decent solution.
It's not that annoying, will look at it again some day later.
There's still the idea of compact modes and I also need to check the behavior on tablets too.

Looked at it for a couple of hours and couldn't find a decent solution. It's not *that* annoying, will look at it again some day later. There's still the idea of compact modes and I also need to check the behavior on tablets too.
swentel commented 2019-01-04 15:15:39 +01:00 (Migrated from github.com)

So after more debugging: holder.content.isExpanded() thinks a row is expanded after clicking one open, which is very interesting ..

So after more debugging: holder.content.isExpanded() thinks a row is expanded after clicking one open, which is very interesting ..
swentel commented 2019-03-23 15:32:37 +01:00 (Migrated from github.com)

Closing

Closing
swentel commented 2019-11-01 13:26:03 +01:00 (Migrated from github.com)

closing, this will be fixed by #41

closing, this will be fixed by #41
This discussion has been locked. Commenting is limited to contributors.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
inhji/indiepass-android#127
No description provided.